linux-kernel - Re: [PATCH v3 49/77] ncr5380: Remove redundant ICR_ARBITRATION_LOST test and eliminate FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5678FF8A.8030105@suse.de>
Date:	Tue, 22 Dec 2015 08:45:14 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v3 49/77] ncr5380: Remove redundant ICR_ARBITRATION_LOST
 test and eliminate FLAG_DTC3181E

On 12/22/2015 02:18 AM, Finn Thain wrote:
> Remove FLAG_DTC3181E. It was used to suppress a final Arbitration Lost
> (SEL asserted) test that isn't actually needed. The test was suppressed
> because it causes problems for DTC436 and DTC536 chips. It takes place
> after the host wins arbitration, so SEL has been asserted. These chips
> can't seem to tell whether it was the host or another bus device that
> did so.
>
> This questionable final test appears in a flow chart in an early NCR5380
> datasheet. It was removed from later documents like the DP5380 datasheet.
>
> By the time this final test takes place, the driver has already tested
> the Arbitration Lost bit several times. The first test happens 3 us after
> BUS FREE (or longer due to register access delays). The protocol requires
> that a device stop signalling within 1.8 us after BUS FREE unless it won
> arbitration, in which case it must assert SEL, which is detected 1.2 us
> later by the first Arbitration Lost test.
>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
>
> ---
>   drivers/scsi/NCR5380.c       |   14 +-------------
>   drivers/scsi/NCR5380.h       |    1 -
>   drivers/scsi/atari_NCR5380.c |    9 ---------
>   drivers/scsi/dmx3191d.c      |    2 +-
>   drivers/scsi/g_NCR5380.c     |    2 +-
>   5 files changed, 3 insertions(+), 25 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/