linux-kernel - Re: [PATCH] OMAPDSS: fix omapfb build error due missing feat functions declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <567900BD.6070907@ti.com>
Date:	Tue, 22 Dec 2015 09:50:21 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Javier Martinez Canillas <javier@....samsung.com>,
	<linux-kernel@...r.kernel.org>
CC:	Tony Lindgren <tony@...mide.com>, <linux-fbdev@...r.kernel.org>,
	Dave Airlie <airlied@...il.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Rob Clark <robdclark@...il.com>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] OMAPDSS: fix omapfb build error due missing feat
 functions declaration

Hi Javier,

On 21/12/15 20:26, Javier Martinez Canillas wrote:
> The omapfb is failing to build in -next due missing declarations for
> dss_feat_get_supported_displays() and dss_feat_get_supported_outputs():
> 
>  CC [M]  drivers/video/fbdev/omap2//omapfb/dss/dss.o
> drivers/video/fbdev/omap2//omapfb/dss/dss.c: In function 'dss_save_context':
> drivers/video/fbdev/omap2//omapfb/dss/dss.c:144:2: error: implicit declaration of function 'dss_feat_get_supported_displays' [-Werror=implicit-function-declaration]
> 
> Add the declaration for these functions in the dss_features.h header
> file to fix this compile error.
> 
> Also, remove the functions export since are not used outside the driver.

Thanks!

Yep, I messed that up. I thought I had tested it, but apparently I only
tested the final for-next only for omapdrm, which does compile and work.

omapdss.h is the the only file still shared between omapdrm and omapfb
after the copy-omapdss-series (I'll work on omapdss.h later), and of
course there was a change to omapdss.h which broke the build.

So I rebased the copy-omapdss-series on top of the rest of the omapdss
patches, and updated the "omapfb: copy omapdss & displays for omapfb" to
make a fresh copy of omapdss for omapfb. I think it's better to update
the series, rather than applying fixes for already confusing series.

I've pushed new version to my for-next branch.

 Tomi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)