linux-kernel - Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151222080446.GZ5284@mwanda>
Date:	Tue, 22 Dec 2015 11:04:46 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, ldv-project@...uxtesting.org,
	Chris Park <chris.park@...el.com>,
	Austin Shin <austin.shin@...el.com>,
	linux-wireless@...r.kernel.org, Johnny Kim <johnny.kim@...el.com>,
	linux-kernel@...r.kernel.org, Tony Cho <tony.cho@...el.com>,
	Leo Kim <leo.kim@...el.com>
Subject: Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure
 path in wilc_wlan_cleanup()

On Mon, Dec 21, 2015 at 12:46:51AM +0300, Alexey Khoroshilov wrote:
> diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
> index a73e99f..4b7c8e9 100644
> --- a/drivers/staging/wilc1000/wilc_wlan.c
> +++ b/drivers/staging/wilc1000/wilc_wlan.c
> @@ -1459,15 +1459,16 @@ void wilc_wlan_cleanup(struct net_device *dev)
>  	ret = p->hif_func.hif_read_reg(wilc, WILC_GP_REG_0, &reg);
>  	if (!ret) {
>  		PRINT_ER("Error while reading reg\n");
> -		release_bus(wilc, RELEASE_ALLOW_SLEEP);
> +		goto _unlock;

If you're redoing this anyway, could we get rid of the underscore in the
label name?  Just unlock: is fine.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/