linux-kernel - Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Dec 2015 09:50:58 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource

On Fri, Dec 18, 2015 at 4:29 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Monday 30 November 2015 09:47:03 Linus Walleij wrote:
>> On Wed, Nov 18, 2015 at 4:21 PM, Arnd Bergmann <arnd@...db.de> wrote:
>>
>> > resource_size_t may be defined as 32 or 64 bit depending on configuration,
>> > so it cannot be printed using the normal format strings, as gcc correctly
>> > warns:
>> >
>> > pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe':
>> > pinctrl-at91-pio4.c:1003:41: warning: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>> >    dev_dbg(dev, "bank %i: hwirq=%u\n", i, res->start);
>> >
>> > This changes the format string to use the special "%pr" format
>> > string that prints a resource, and changes the arguments so we
>> > the resource structure directly.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> > ---
>> > v2: don't break ordering of arguments, that part was correct already, unlike
>> > what I said in v1.
>>
>> Patch applied with Ludovic's review tag.
>
> I don't see this in linux-next, did the commit get lost accidentally?

No, it's just that I screwed up the next branch so many times and
Stephen has not been able to pull it into linux-next.

Hope it works now...

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/