lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <56791422.4050407@mev.co.uk>
Date:	Tue, 22 Dec 2015 09:13:06 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	maomao xu <albert008.xu@...il.com>, hsweeten@...ionengravers.com,
	gregkh@...uxfoundation.org, colinpatrickcronin@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix block comments coding style issue in
 comedi.h

On 22/12/15 05:41, maomao xu wrote:
> Fix up block comments to make a trailing */ on a separate line
>
> Signed-off-by: maomao xu <albert008.xu@...il.com>
> ---
>   drivers/staging/comedi/comedi.h |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 66edda1..ec5e59c 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -895,7 +895,8 @@ enum amplc_dio_ts_clock_src {
>   };
>
>   /* Values for setting a gate source with INSN_CONFIG_SET_GATE_SRC for
> - * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver). */
> + * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver).
> + */
>   enum amplc_dio_gate_source {
>   	AMPLC_DIO_GAT_VCC,	/* internal high logic level */
>   	AMPLC_DIO_GAT_GND,	/* internal low logic level */
>

Sorry, this clashes with another patch in Greg's staging-next branch. 
Also, it doesn't use the preferred block comment style with the leading 
'/*' on a separate line.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ