[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VfU74zvwBef682bVqL-aSYVRYeEyPjyarE_KRyLr+8NQw@mail.gmail.com>
Date: Tue, 22 Dec 2015 11:58:17 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
Jiri Slaby <jslaby@...e.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v3] serial: 8250: add gpio support to exar
On Tue, Dec 22, 2015 at 6:27 AM, Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
> On Mon, Dec 21, 2015 at 08:28:51PM +0200, Andy Shevchenko wrote:
>> On Mon, Dec 21, 2015 at 5:19 PM, Sudip Mukherjee
>> <sudipm.mukherjee@...il.com> wrote:
>>
>> There are at least two approaches:
>> - use 8250_pci, etc as a library (see example: 8250_mid.c)
>> - force 8250_pci to use external libraries in some cases (seems your approach)
Third one btw is to blow up the 8250_pci. (This actually was the main
reason why we chose separate driver approach in our case).
>> Of course better to gather maintainer's opinion first.
>
> Greg, can you please give some idea here about the best way to approach...
> I personally think, having it as a module with the minor changes that
> Alan and Andy has suggested is the best approach.
> The only downside is
> that the module gets loaded even if the device is not there.
How is that?
> But for
> arguments sake, the module will be enabled in the config only if someone
> is interested to build it. Everyone has the option to disable it if
> required.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists