linux-kernel - Re: [alsa-devel] [PATCH] ALSA: usb-audio: use list_for_each_entry_continue_reverse

Open Source and information security mailing list archives

Message-ID: <s5hegeeg5yi.wl-tiwai@suse.de>
Date:	Tue, 22 Dec 2015 10:58:45 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Geliang Tang <geliangtang@....com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Ricard Wanderlof <ricard.wanderlof@...s.com>,
	Johan Rastén <johan@...ud.se>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: use	list_for_each_entry_continue_reverse

On Mon, 21 Dec 2015 16:55:39 +0100,
Geliang Tang wrote:
> 
> For better readability, use list_for_each_entry_continue_reverse()
> in have_dup_chmap().
> 
> Signed-off-by: Geliang Tang <geliangtang@....com>

Applied, thanks.

Takashi

> ---
>  sound/usb/stream.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/usb/stream.c b/sound/usb/stream.c
> index 8ee14f2..c4dc577 100644
> --- a/sound/usb/stream.c
> +++ b/sound/usb/stream.c
> @@ -125,11 +125,9 @@ static int usb_chmap_ctl_info(struct snd_kcontrol *kcontrol,
>  static bool have_dup_chmap(struct snd_usb_substream *subs,
>  			   struct audioformat *fp)
>  {
> -	struct list_head *p;
> +	struct audioformat *prev = fp;
>  
> -	for (p = fp->list.prev; p != &subs->fmt_list; p = p->prev) {
> -		struct audioformat *prev;
> -		prev = list_entry(p, struct audioformat, list);
> +	list_for_each_entry_continue_reverse(prev, &subs->fmt_list, list) {
>  		if (prev->chmap &&
>  		    !memcmp(prev->chmap, fp->chmap, sizeof(*fp->chmap)))
>  			return true;
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives