linux-kernel - Re: [PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5679377B.3030004@redhat.com>
Date:	Tue, 22 Dec 2015 12:43:55 +0100
From:	Hans de Goede <hdegoede@...hat.com>
To:	Chen-Yu Tsai <wens@...e.org>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly

Hi,

On 22-12-15 05:27, Chen-Yu Tsai wrote:
> The driver allocates the spinlock but fails to initialize it correctly.
> The kernel reports a BUG indicating bad spinlock magic when spinlock
> debugging is enabled.
>
> Call spin_lock_init() on it to initialize it correctly.
>
> Fixes: b4e3e59fb59c ("[media] rc: add sunxi-ir driver")
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Good catch:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   drivers/media/rc/sunxi-cir.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c
> index 7830aef3db45..40f77685cc4a 100644
> --- a/drivers/media/rc/sunxi-cir.c
> +++ b/drivers/media/rc/sunxi-cir.c
> @@ -153,6 +153,8 @@ static int sunxi_ir_probe(struct platform_device *pdev)
>   	if (!ir)
>   		return -ENOMEM;
>
> +	spin_lock_init(&ir->ir_lock);
> +
>   	if (of_device_is_compatible(dn, "allwinner,sun5i-a13-ir"))
>   		ir->fifo_size = 64;
>   	else
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/