linux-kernel - Re: [PATCH v2] rt: x86: enable preemption in IST exception for x86-32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151222120628.GA27274@linutronix.de>
Date:	Tue, 22 Dec 2015 13:06:28 +0100
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Yang Shi <yang.shi@...aro.org>
Cc:	tglx@...utronix.de, rostedt@...dmis.org,
	linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org,
	linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH v2] rt: x86: enable preemption in IST exception for x86-32

* Yang Shi | 2015-12-14 15:06:44 [-0800]:

>Mainline kernel commit 959274753857efe9c5f1ba35fe727f51e9aa128d
>("x86, traps: Track entry into and exit from IST context"), introduced
>ist_enter which disables preemption uncondiontionally for both x86-64 and
>x86-32. However, x86-32 does not have an IST and the stack still belongs to
>the current task and there is no problem in scheduling out the task.

no no. So from a quick look I *assumed* you merged your v1 and revert of the
Steven's patch into one piece. But now I see that you don't disable preemption
64bit which means you revert upstream change.

Here is what happens:
- I drop your v2
- I merge your v1 with updated patch description
- I revert "x86: Do not disable preemption in int3 on 32bit". If someone
  wants to skip the delayed signal on 32bit please address this upstream
  first (that is skip the preempt_disable() on 32bit if it is not
  required there).
- Yang Shi, please send a changelong if you send incremental patches.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/