linux-kernel - Re: [PATCH 1/2] ARM: dts: ts-4800: Add LCD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Dec 2015 20:24:35 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Damien Riegel <damien.riegel@...oirfairelinux.com>
Cc:	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Sascha Hauer <kernel@...gutronix.de>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	kernel@...oirfairelinux.com
Subject: Re: [PATCH 1/2] ARM: dts: ts-4800: Add LCD support

On Mon, Dec 21, 2015 at 01:40:59PM -0500, Damien Riegel wrote:
> > > @@ -30,6 +30,60 @@
> > >  			clock-frequency = <24576000>;
> > >  		};
> > >  	};
> > > +
> > > +	regulators {
> > > +		compatible = "simple-bus";
> > > +		#address-cells = <1>;
> > > +		#size-cells = <0>;
> > > +
> > > +		backlight_reg: regulator@0 {
> > > +			compatible = "regulator-fixed";
> > > +			reg = <0>;
> > > +			pinctrl-names = "default";
> > > +			pinctrl-0 = <&pinctrl_enable_lcd>;
> > > +			regulator-name = "enable_lcd_reg";
> > > +			regulator-min-microvolt = <3300000>;
> > > +			regulator-max-microvolt = <3300000>;
> > > +			gpio = <&gpio4 9 GPIO_ACTIVE_HIGH>;
> > > +			enable-active-high;
> > > +		};
> > > +	};
> > 
> > DT maintainers dislike this fake simple-bus container.  Let's put the
> > regulator directly under root like below.
> > 
> >         backlight_reg: regulator-backlight {
> >                 compatible = "regulator-fixed";
> >                 pinctrl-names = "default";
> >                 pinctrl-0 = <&pinctrl_enable_lcd>;
> >                 regulator-name = "enable_lcd_reg";
> >                 regulator-min-microvolt = <3300000>;
> >                 regulator-max-microvolt = <3300000>;
> >                 gpio = <&gpio4 9 GPIO_ACTIVE_HIGH>;
> >                 enable-active-high;
> >         };
> > 
> > I fixed it up and applied both patches.
> 
> Thank you. I am using the imx51-*.dts as examples, maybe they should be
> updated to be consistent with the newer device tree style? I'm willing
> to do that but I don't want to make changes on dts files that I can't
> test.

Leave them there for now.

> 
> Sidenote: your Signed-off-by is missing on these two patches.

Oops.  Thanks.  Fixed now.

Shawn


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/