linux-kernel - Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Dec 2015 21:36:30 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Matthias Brugger <matthias.bgg@...il.com>
Cc:	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@...ts.infradead.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Arnd Bergmann <arnd@...db.de>, paul.gortmaker@...driver.com,
	Eddie Huang (黃智傑) 
	<eddie.huang@...iatek.com>, James Liao <jamesjj.liao@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform_driver

Hi Matthias,

One thing below is missing from this version of the patch...

> On Fri, Dec 18, 2015 at 7:19 PM, Matthias Brugger
> <matthias.bgg@...il.com> wrote:
>> SCPSYS can't be built as module. Use builtin_platform_driver instead.
>> For this probe must not be __init and the data accessed can't be
>> __initconst. Remove this macros. To make the impact as small as possible,
>> fold scp_domain_data into scp_domain via a pointer.

[snip]

>> @@ -542,10 +533,11 @@ static const struct of_device_id of_scpsys_match_tbl[] = {
>>  };
>>
>>  static struct platform_driver scpsys_drv = {
>> +       .probe = scpsys_probe,
>>         .driver = {
>>                 .name = "mtk-scpsys",

This was in Sascha's version of the patch:

  .suppress_bind_attrs = true,

Do we still need it now that we use "builtin_platform_driver"?

>>                 .owner = THIS_MODULE,
>>                 .of_match_table = of_match_ptr(of_scpsys_match_tbl),
>>         },
>>  };
>> -builtin_platform_driver_probe(scpsys_drv, scpsys_probe);
>> +builtin_platform_driver(scpsys_drv);
>> --
>> 2.6.2
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/