linux-kernel - Re: [PATCH 1/1] dmi_scan: uuid: fix endianess for smbios >= 0x206

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151222151751.GA2279@codeblueprint.co.uk>
Date:	Tue, 22 Dec 2015 15:17:51 +0000
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Andrea Arcangeli <aarcange@...hat.com>
Cc:	Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Federico Simoncelli <fsimonce@...hat.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jean Delvare <jdelvare@...e.de>
Subject: Re: [PATCH 1/1] dmi_scan: uuid: fix endianess for smbios >= 0x206

(Cc'ing Jean since he's the maintainer)

On Tue, 22 Dec, at 02:53:10PM, Andrea Arcangeli wrote:
> The dmi_ver wasn't updated correctly before the dmi_decode method run
> to save the uuid.
> 
> That resulted in "dmidecode -s system-uuid" and
> /sys/class/dmi/id/product_uuid disagreeing. The latter was buggy and
> this fixes it.
> 
> Reported-by: Federico Simoncelli <fsimonce@...hat.com>
> Signed-off-by: Andrea Arcangeli <aarcange@...hat.com>
> ---
>  drivers/firmware/dmi_scan.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
> index ac1ce4a..0e08e66 100644
> --- a/drivers/firmware/dmi_scan.c
> +++ b/drivers/firmware/dmi_scan.c
> @@ -521,6 +521,7 @@ static int __init dmi_present(const u8 *buf)
>  			dmi_ver = smbios_ver;
>  		else
>  			dmi_ver = (buf[14] & 0xF0) << 4 | (buf[14] & 0x0F);
> +		dmi_ver <<= 8;
>  		dmi_num = get_unaligned_le16(buf + 12);
>  		dmi_len = get_unaligned_le16(buf + 6);
>  		dmi_base = get_unaligned_le32(buf + 8);
> @@ -528,15 +529,14 @@ static int __init dmi_present(const u8 *buf)
>  		if (dmi_walk_early(dmi_decode) == 0) {
>  			if (smbios_ver) {
>  				pr_info("SMBIOS %d.%d present.\n",
> -				       dmi_ver >> 8, dmi_ver & 0xFF);
> +					dmi_ver >> 16, (dmi_ver >> 8) & 0xFF);
>  			} else {
>  				smbios_entry_point_size = 15;
>  				memcpy(smbios_entry_point, buf,
>  				       smbios_entry_point_size);
>  				pr_info("Legacy DMI %d.%d present.\n",
> -				       dmi_ver >> 8, dmi_ver & 0xFF);
> +					dmi_ver >> 16, (dmi_ver >> 8) & 0xFF);
>  			}
> -			dmi_ver <<= 8;
>  			dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
>  			printk(KERN_DEBUG "DMI: %s\n", dmi_ids_string);
>  			return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/