linux-kernel - RE: [PATCH 0/7][v4] Add OTG support for FSL socs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871taepcp2.fsf@saruman.tx.rr.com>
Date:	Tue, 22 Dec 2015 12:20:41 -0600
From:	Felipe Balbi <balbi@...com>
To:	Ramneek Mehresh <ramneek.mehresh@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"stern@...land.harvard.edu" <stern@...land.harvard.edu>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs


Hi,

Ramneek Mehresh <ramneek.mehresh@...escale.com> writes:
>> -----Original Message-----
>> From: Felipe Balbi [mailto:balbi@...com]
>> Sent: Saturday, October 10, 2015 3:04 AM
>> To: Mehresh Ramneek-B31383 <ramneek.mehresh@...escale.com>; linux-
>> kernel@...r.kernel.org
>> Cc: stern@...land.harvard.edu; gregkh@...uxfoundation.org; linux-
>> usb@...r.kernel.org; Mehresh Ramneek-B31383
>> <ramneek.mehresh@...escale.com>
>> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
>> 
>> Felipe Balbi <balbi@...com> writes:
>> 
>> > Hi,
>> >
>> > Ramneek Mehresh <ramneek.mehresh@...escale.com> writes:
>> >> Add support for otg for all freescale socs having internal usb phy.
>> >>
>> >> Ramneek Mehresh (7):
>> >>   usb:fsl:otg: Make fsl otg driver as tristate
>> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>> >>   usb:fsl:otg: Add support to add/remove usb host driver
>> >>   usb:fsl:otg: Signal host drv when host is otg
>> >>   usb:fsl:otg: Modify otg_event to start host drv
>> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>> >>   usb:fsl:otg: Add host-gadget drv sync delay
>> >
>> > Unless Alan's okay with the host side changes, I can't accept any of
>> > these. However, I must say some of the flags you add here already
>> > exist in some way, shape or form. For example, look at is_b_host flag.
>>
>
> Could you please be more specific...which flag you think that I should
>remove/I'm re-defining. The flags I'm defining are:
>
> have_hcd : defined in fsl specific structure for fsl specific use-case
>
> had_hcd: defined in fsl specific structure for fsl specific use-case
>
> is_otg : defined in include/linux/usb.h
>
> Are you suggesting using otg_port or is_b_host instead of is_otg?
>
> As I understand, is_b_host is specifically to check if an otg B device
> is in host mode...correct?  I just need a flag to check if a
> controller is capable of otg operations? That's why defined "is_otg"
> flag. Please suggest.

no, I don't know why I made that comment. You could use otg_port, but
that wouldn't look very clean. Can you resend with Alan's ack, then I'll
move this series into testing/next.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)