linux-kernel - Re: [PATCH] rtc: rv8803: fix handling return value of i2c_smbus_read_byte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151222185414.GB8623@piout.net>
Date:	Tue, 22 Dec 2015 19:54:14 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Andrzej Hajda <a.hajda@...sung.com>
Cc:	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
	<rtc-linux@...glegroups.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: rv8803: fix handling return value of
 i2c_smbus_read_byte_data

On 10/12/2015 at 08:55:33 +0100, Andrzej Hajda wrote :
> The function can return negative values, so its result should
> be assigned to signed variable.
> 
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
> 
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
> 
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> ---
>  drivers/rtc/rtc-rv8803.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/