linux-kernel - Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201512222306.58681.arnd@arndb.de>
Date:	Tue, 22 Dec 2015 23:06:58 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Andre Przywara <andre.przywara@....com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	"Chen-Yu Tsai" <wens@...e.org>,
	Herbert Xu <herbert@...dor.apana.org.au>, marc.zyngier@....com,
	catalin.marinas@....com, will.deacon@....com,
	linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com,
	Corentin Labbe <clabbe.montjoie@...il.com>,
	linux-crypto@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types

On Tuesday 22 December 2015, Andre Przywara wrote:
> The min3() macro expects all arguments to be of the same type (or
> size at least). While two arguments are ints or u32s, one is size_t,
> which does not match on 64-bit architectures.
> Cast the size_t to u32 to make min3() happy. In this context here the
> length should never exceed 32 bits anyway.
> 
> Signed-off-by: Andre Przywara <andre.przywara@....com>

Looks correct, but a bit ugly. Could we avoid the casts by using
temporary variables to keep the size_t based data?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/