linux-kernel - Re: [PATCH v3 1/2] crypto: KEYS: convert public key to the akcipher api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Dec 2015 13:38:56 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Tadeusz Struk <tadeusz.struk@...el.com>
Cc:	kbuild-all@...org, herbert@...dor.apana.org.au,
	tadeusz.struk@...el.com, linux-kernel@...r.kernel.org,
	dhowells@...hat.com, linux-security-module@...r.kernel.org,
	linux-crypto@...r.kernel.org, zohar@...ux.vnet.ibm.com
Subject: Re: [PATCH v3 1/2] crypto: KEYS: convert public key to the akcipher
 api

Hi Tadeusz,

[auto build test ERROR on cryptodev/master]
[also build test ERROR on v4.4-rc6 next-20151223]

url:    https://github.com/0day-ci/linux/commits/Tadeusz-Struk/crypto-KEYS-convert-public-key-to-akcipher-api/20151223-132001
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

Note: the linux-review/Tadeusz-Struk/crypto-KEYS-convert-public-key-to-akcipher-api/20151223-132001 HEAD 06fa55a0feec438fdc649cdac682af7ab99f8099 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   security/integrity/digsig_asymmetric.c: In function 'asymmetric_verify':
>> security/integrity/digsig_asymmetric.c:95:5: error: 'struct public_key_signature' has no member named 'nr_mpi'
     pks.nr_mpi = 1;
        ^
>> security/integrity/digsig_asymmetric.c:96:5: error: 'struct public_key_signature' has no member named 'rsa'
     pks.rsa.s = mpi_read_raw_data(hdr->sig, siglen);
        ^
>> security/integrity/digsig_asymmetric.c:96:2: error: implicit declaration of function 'mpi_read_raw_data' [-Werror=implicit-function-declaration]
     pks.rsa.s = mpi_read_raw_data(hdr->sig, siglen);
     ^
   security/integrity/digsig_asymmetric.c:98:9: error: 'struct public_key_signature' has no member named 'rsa'
     if (pks.rsa.s)
            ^
>> security/integrity/digsig_asymmetric.c:101:2: error: implicit declaration of function 'mpi_free' [-Werror=implicit-function-declaration]
     mpi_free(pks.rsa.s);
     ^
   security/integrity/digsig_asymmetric.c:101:14: error: 'struct public_key_signature' has no member named 'rsa'
     mpi_free(pks.rsa.s);
                 ^
   cc1: some warnings being treated as errors

vim +95 security/integrity/digsig_asymmetric.c

e0751257 Dmitry Kasatkin 2013-02-07   89  
e0751257 Dmitry Kasatkin 2013-02-07   90  	memset(&pks, 0, sizeof(pks));
e0751257 Dmitry Kasatkin 2013-02-07   91  
e0751257 Dmitry Kasatkin 2013-02-07   92  	pks.pkey_hash_algo = hdr->hash_algo;
e0751257 Dmitry Kasatkin 2013-02-07   93  	pks.digest = (u8 *)data;
e0751257 Dmitry Kasatkin 2013-02-07   94  	pks.digest_size = datalen;
e0751257 Dmitry Kasatkin 2013-02-07  @95  	pks.nr_mpi = 1;
e0751257 Dmitry Kasatkin 2013-02-07  @96  	pks.rsa.s = mpi_read_raw_data(hdr->sig, siglen);
e0751257 Dmitry Kasatkin 2013-02-07   97  
e0751257 Dmitry Kasatkin 2013-02-07   98  	if (pks.rsa.s)
e0751257 Dmitry Kasatkin 2013-02-07   99  		ret = verify_signature(key, &pks);
e0751257 Dmitry Kasatkin 2013-02-07  100  
e0751257 Dmitry Kasatkin 2013-02-07 @101  	mpi_free(pks.rsa.s);
e0751257 Dmitry Kasatkin 2013-02-07  102  	key_put(key);
e0751257 Dmitry Kasatkin 2013-02-07  103  	pr_debug("%s() = %d\n", __func__, ret);
e0751257 Dmitry Kasatkin 2013-02-07  104  	return ret;

:::::: The code at line 95 was first introduced by commit
:::::: e0751257a64ea10cca96ccb06522bfb10e36cb5b ima: digital signature verification using asymmetric keys

:::::: TO: Dmitry Kasatkin <dmitry.kasatkin@...el.com>
:::::: CC: Mimi Zohar <zohar@...ux.vnet.ibm.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (43276 bytes)