linux-kernel - Re: [PATCH 2/5] watchdog: Separate and maintain variables based on variable lifetime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5679EBB3.2000707@roeck-us.net>
Date:	Tue, 22 Dec 2015 16:32:51 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Tomas Winkler <tomasw@...il.com>
Cc:	Hans de Goede <hdegoede@...hat.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>,
	Damien Riegel <damien.riegel@...oirfairelinux.com>,
	Pratyush Anand <panand@...hat.com>
Subject: Re: [PATCH 2/5] watchdog: Separate and maintain variables based on
 variable lifetime

On 12/22/2015 02:05 PM, Tomas Winkler wrote:

>
>  > Do you see a situation where holding the lock between calls into the driver
>  > might be a problem ?
>
> I don't think u are holding the lock now in watchdog_unregister when WDOG_UNREGISTERED was dropped.

the lock is held while clearing the pointers:

	mutex_lock(&wd_data->lock);
         wd_data->wdd = NULL;
         wdd->wd_data = NULL;
         mutex_unlock(&wd_data->lock);

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/