linux-kernel - Re: [PATCH 5/8] perf script: Add stat default handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151223160136.GA14636@krava.brq.redhat.com>
Date:	Wed, 23 Dec 2015 17:01:36 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"Liang, Kan" <kan.liang@...el.com>
Subject: Re: [PATCH 5/8] perf script: Add stat default handlers

On Wed, Dec 23, 2015 at 10:40:38PM +0900, Namhyung Kim wrote:
> On Tue, Dec 22, 2015 at 04:43:31PM +0100, Jiri Olsa wrote:
> > Implement struct scripting_ops::(process_stat|process_stat_interval)
> > handlers - calling scripting handlers from stat events handlers.
> > 
> > Tested-by: Kan Liang <kan.liang@...el.com>
> > Link: http://lkml.kernel.org/n/tip-3iu6vmvuur1bntbnh43v3bib@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> >  tools/perf/builtin-script.c | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> > 
> > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> > index a90bc0b81e70..656541eff151 100644
> > --- a/tools/perf/builtin-script.c
> > +++ b/tools/perf/builtin-script.c
> > @@ -221,6 +221,9 @@ static int perf_evsel__check_attr(struct perf_evsel *evsel,
> >  	struct perf_event_attr *attr = &evsel->attr;
> >  	bool allow_user_set;
> >  
> > +	if (perf_header__has_feat(&session->header, HEADER_STAT))
> > +		return 0;
> > +
> >  	allow_user_set = perf_header__has_feat(&session->header,
> >  					       HEADER_AUXTRACE);
> >  
> > @@ -674,6 +677,18 @@ static void process_event(struct perf_script *script __maybe_unused, union perf_
> >  
> >  static struct scripting_ops	*scripting_ops;
> >  
> > +static void process_stat(struct perf_evsel *counter, u64 time)
> > +{
> > +	if (scripting_ops)
> > +		scripting_ops->process_stat(&stat_config, counter, time);
> 
> Shouldn't it be
> 
> 	if (scripting_ops && scripting_ops->process_stat)
> 
> ?  It seems you only set it for python in patch 7..

right.. forgot about perf completely..

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/