| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <567C0E87.7020007@roeck-us.net> Date: Thu, 24 Dec 2015 07:25:59 -0800 From: Guenter Roeck <linux@...ck-us.net> To: Damien Riegel <damien.riegel@...oirfairelinux.com> Cc: linux-watchdog@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers On 12/24/2015 07:07 AM, Damien Riegel wrote: > On Wed, Dec 23, 2015 at 09:11:28PM -0800, Guenter Roeck wrote: >> The 'dev' variable in watchdog drivers has a different lifetime than the >> watchdog character device and should therefore not be used by watchdog >> drivers. >> >> Some of the drivers use the variable to print kernel messages. Those are >> either dropped or converted to use pr_ functions. One driver sets the >> variable during initialization to the watchdog driver's parent device, >> which is wrong and also removed. > > Hi Guenter, > > For gpio_wdt and mena21_wdt, wdd->parent is set and could be used for > dev_* printings. Do you prefer to keep this variable only for watchdog > core internal usage? Otherwise, the serie looks good. > Good idea, I'll use ->parent for those. ->parent is set by the driver, so it is safe to be used by the driver. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists