linux-kernel - Re: [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <567B5DEC.3050106@ti.com>
Date:	Wed, 23 Dec 2015 20:52:28 -0600
From:	"Andrew F. Davis" <afd@...com>
To:	"H. Nikolaus Schaller" <hns@...delico.com>,
	Pali Rohár <pali.rohar@...il.com>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
CC:	<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<gta04-owner@...delico.com>, <marek@...delico.com>
Subject: Re: [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500

On 12/17/2015 04:12 AM, H. Nikolaus Schaller wrote:
> bug: according to data sheet some register numbers are wrong.
>
> tested: no
>
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>

Indeed they are, good catch.

Acked-by: Andrew F. Davis <afd@...com>

> ---
>   drivers/power/bq27xxx_battery.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index e54a125..f9a5f4f 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -198,10 +198,10 @@ static u8 bq27500_regs[] = {
>   	INVALID_REG_ADDR,	/* TTECP - NA	*/
>   	0x0c,	/* NAC		*/
>   	0x12,	/* LMD(FCC)	*/
> -	0x1e,	/* CYCT		*/
> +	0x2a,	/* CYCT		*/
>   	INVALID_REG_ADDR,	/* AE - NA	*/
> -	0x20,	/* SOC(RSOC)	*/
> -	0x2e,	/* DCAP(ILMD)	*/
> +	0x2c,	/* SOC(RSOC)	*/
> +	0x3c,	/* DCAP(ILMD)	*/
>   	INVALID_REG_ADDR,	/* AP - NA	*/
>   };
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/