| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <567D681E.7050903@users.sourceforge.net> Date: Fri, 25 Dec 2015 17:00:30 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: linux-ide@...r.kernel.org, Tejun Heo <tj@...nel.org> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: sata_mv: Another source code review around exception handling? Hello, I have looked at the source file for the Marvell SATA support driver once more. I would appreciate if a specific implementation detail can be clarified there. Static source code analysis can point out that functions like the following are called by the mv_platform_probe() function. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/ata/sata_mv.c?id=80c75a0f1d81922bf322c0634d1e1a15825a89e6#n4055 * ata_host_alloc_pinfo http://lxr.free-electrons.com/source/drivers/ata/libata-core.c?v=4.3#L5768 * devm_kzalloc http://lxr.free-electrons.com/source/include/linux/device.h?v=4.3#L645 The value "-ENOMEM" will be returned if one of these function calls failed. Can it be that any system resources (like memory) are not appropriately released if any calls of this sequence succeeded before the failure? Is the use of the single jump label "err" also suspicious here? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists