linux-kernel - Re: [PATCH v3] um: Fix build error and kconfig for i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151225013409.GC12977@x>
Date:	Thu, 24 Dec 2015 17:34:09 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Mickaël Salaün <mic@...ikod.net>
Cc:	linux-kernel@...r.kernel.org, Jeff Dike <jdike@...toit.com>,
	Richard Weinberger <richard@....at>,
	user-mode-linux-devel@...ts.sourceforge.net,
	"Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
	Michal Marek <mmarek@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH v3] um: Fix build error and kconfig for i386

On Thu, Dec 24, 2015 at 01:12:11PM +0100, Mickaël Salaün wrote:
> Fix build error by generating elfcore.o only when ELF_CORE (depending on
> COREDUMP) is selected:
> 
> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> (.text+0x3e62): undefined reference to `dump_emit'
> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> (.text+0x3eef): undefined reference to `dump_emit'
> 
> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>
> Cc: Jeff Dike <jdike@...toit.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Josh Triplett <josh@...htriplett.org>
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: Michal Marek <mmarek@...e.cz>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>

It looks like ELF_CORE depends on COREDUMP, but not on BINFMT_ELF.
Should it?  What happens if you build this with ELF_CORE=y and
BINFMT_ELF=n?  Does that configuration even make sense?

>  arch/x86/um/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/um/Makefile b/arch/x86/um/Makefile
> index a8fecc226946..3ee2bb6b440b 100644
> --- a/arch/x86/um/Makefile
> +++ b/arch/x86/um/Makefile
> @@ -17,7 +17,7 @@ obj-y = bug.o bugs_$(BITS).o delay.o fault.o ksyms.o ldt.o \
>  ifeq ($(CONFIG_X86_32),y)
>  
>  obj-y += checksum_32.o
> -obj-$(CONFIG_BINFMT_ELF) += elfcore.o
> +obj-$(CONFIG_ELF_CORE) += elfcore.o
>  
>  subarch-y = ../lib/string_32.o ../lib/atomic64_32.o ../lib/atomic64_cx8_32.o
>  subarch-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += ../lib/rwsem.o
> -- 
> 2.6.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/