linux-kernel - Re: [PATCH 6/7] drivers: net: cpsw: fix error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1512261838330.2064@localhost6.localdomain6>
Date:	Sat, 26 Dec 2015 18:40:54 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
cc:	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] drivers: net: cpsw: fix error return code

> > diff --git a/drivers/net/ethernet/ti/cpsw.c
> > b/drivers/net/ethernet/ti/cpsw.c
> > index 3409e80..6a76992 100644
> > --- a/drivers/net/ethernet/ti/cpsw.c
> > +++ b/drivers/net/ethernet/ti/cpsw.c
> > @@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device *pdev)
> > 
> >   	/* RX IRQ */
> >   	irq = platform_get_irq(pdev, 1);
> > -	if (irq < 0)
> > +	if (irq < 0) {
> > +		ret = -ENOENT;
> 
>    Why not just propagate an error returned by that function?

OK, I did what was done a few lines before in the same function:

        ndev->irq = platform_get_irq(pdev, 1);
        if (ndev->irq < 0) {
		dev_err(priv->dev, "error getting irq resource\n");
                ret = -ENOENT;
                goto clean_ale_ret;
        }

Maybe they should all be changed?

julia

> >   		goto clean_ale_ret;
> > +	}
> > 
> >   	priv->irqs_table[0] = irq;
> >   	ret = devm_request_irq(&pdev->dev, irq, cpsw_rx_interrupt,
> > @@ -2461,8 +2463,10 @@ static int cpsw_probe(struct platform_device *pdev)
> > 
> >   	/* TX IRQ */
> >   	irq = platform_get_irq(pdev, 2);
> > -	if (irq < 0)
> > +	if (irq < 0) {
> > +		ret = -ENOENT;
> 
>    Likewise?
> 
> [...]
> 
> MBR, Sergei
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/