linux-kernel - Re: [PATCH v3 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151227212059.GN30359@lukather>
Date:	Sun, 27 Dec 2015 22:20:59 +0100
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Vishnu Patekar <vishnupatekar0510@...il.com>
Cc:	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	Emilio Lopez <emilio@...pez.com.ar>,
	Linus Walleij <linus.walleij@...aro.org>,
	Jens Kuske <jenskuske@...il.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Chen-Yu Tsai <wens@...e.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-sunxi@...glegroups.com" <linux-sunxi@...glegroups.com>,
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi

On Tue, Dec 22, 2015 at 05:41:22PM +0800, Vishnu Patekar wrote:
> >> +     clocks {
> >> +             #address-cells = <1>;
> >> +             #size-cells = <1>;
> >> +             ranges;
> >> +
> >> +             osc24M: osc24M_clk {
> >> +                     #clock-cells = <0>;
> >> +                     compatible = "fixed-clock";
> >> +                     clock-frequency = <24000000>;
> >> +                     clock-output-names = "osc24M";
> >> +             };
> >> +
> >> +             osc32k: osc32k_clk {
> >> +                     #clock-cells = <0>;
> >> +                     compatible = "fixed-clock";
> >> +                     clock-frequency = <32768>;
> >> +                     clock-output-names = "osc32k";
> >> +             };
> >
> > Do you need to modify the clocks driver in your first commit then?
> I did not get what you are trying to say here, could you please elaborate?
> 
> I'll correct mistakes, and re-send this patch, is it okie?

In your first patch, you add a CLK_OF_DECLARE for the H3 compatible in
clk-sunxi.c

Judging from your clocks node above, you don't need it at all.

I'm guessing you'll need it later on, but I wanted to know if that was
intentional :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)