linux-kernel - Re: [PATCH] Fix ld-version.sh to handle large 3rd version part

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151227223623.GF25832@tassilo.jf.intel.com>
Date:	Sun, 27 Dec 2015 14:36:23 -0800
From:	Andi Kleen <ak@...ux.intel.com>
To:	James Hogan <james.hogan@...tec.com>
Cc:	Ralf Baechle <ralf@...ux-mips.org>, linux-kernel@...r.kernel.org,
	Michal Marek <mmarek@...e.cz>,
	Guenter Roeck <linux@...ck-us.net>, linux-mips@...ux-mips.org
Subject: Re: [PATCH] Fix ld-version.sh to handle large 3rd version part

On Sat, Dec 26, 2015 at 10:47:52PM +0000, James Hogan wrote:
> The ld-version.sh script doesn't handle versions with large (>= 10) 3rd
> version components, because the 2nd component is only multiplied by 10
> times that of the 3rd component.
> 
> For example the following version string:
> GNU ld (Codescape GNU Tools 2015.06-05 for MIPS MTI Linux) 2.24.90
> 
> gives a bogus version number:
>  20000000
> + 2400000
> +  900000 = 23300000
> 
> Breakage, confusion and mole-whacking ensues.

Thanks. Looks good. I'll fix the LTO tree.

Reviewed-by: Andi Kleen <ak@...ux.intel.com>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/