| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Dec 2015 16:12:26 +0100 (CET) From: Julia Lawall <julia.lawall@...6.fr> To: SF Markus Elfring <elfring@...rs.sourceforge.net> cc: linux-media@...r.kernel.org, Mauro Carvalho Chehab <mchehab@....samsung.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [media] m88rs6000t: Better exception handling in five functions On Mon, 28 Dec 2015, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "ret" will not be checked once more > >> after a function call. > > > > This commit message fits with the previous change. > > Do you prefer an other wording? Something like "Split the return into success and error cases, to avoid the need for testing before logging." The concept of the return being duplicated didn't come across in your message. > > It could be nice to put a blank line before the error handling code. > > Is it really a coding style requirement to insert another blank line between > the suggested placement of the statement "return 0;" and the jump label? I don't think it is a requirement. But some files do it, and if other functions in this file do it, then it would be nice to do the same. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists