linux-kernel - Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5680F1C0.7080505@linux.intel.com>
Date:	Mon, 28 Dec 2015 16:24:32 +0800
From:	Jiang Liu <jiang.liu@...ux.intel.com>
To:	Jeremiah Mahler <jmmahler@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Joe Lawrence <joe.lawrence@...atus.com>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Borislav Petkov <bp@...en8.de>, andy.shevchenko@...il.com,
	Guenter Roeck <linux@...ck-us.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct
 apic_chip_data.old_domain as temporary buffer

On 2015/12/24 13:15, Jeremiah Mahler wrote:
> Jiang,
> 
> On Wed, Dec 23, 2015 at 10:13:26PM +0800, Jiang Liu wrote:
>> Function __assign_irq_vector() makes use of apic_chip_data.old_domain
>> as a temporary buffer, which causes trouble to rollback logic in case of
>> failure. So use a dedicated temporary buffer for __assign_irq_vector().
>>
>> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
>> ---
>>  arch/x86/kernel/apic/vector.c |    9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
> [...]
> 
> I tried this patch and the rest in the series but unfortunately
> the bug is still present.
> 
>   [   10.184649] wlan0: authenticated
>   [   10.187883] wlan0: associate with 02:1a:11:fb:90:1c (try 1/3)
>   [   10.191574] do_IRQ: 0.35 No irq handler for vector
>   [   10.191589] do_IRQ: 0.35 No irq handler for vector
>   [   10.198159] do_IRQ: 0.35 No irq handler for vector
>   [   10.198165] do_IRQ: 0.35 No irq handler for vector
>   [   10.200534] wlan0: RX AssocResp from 02:1a:11:fb:90:1c (capab=0x431
>   status=0 aid=1)
>   [   10.204611] wlan0: associated
>   [   10.238883] do_IRQ: 0.35 No irq handler for vector
>   [   10.238892] do_IRQ: 0.35 No irq handler for vector
>   [   10.280716] do_IRQ: 0.35 No irq handler for vector
>   [   10.281083] do_IRQ: 0.35 No irq handler for vector
>   [   10.286484] do_IRQ: 0.35 No irq handler for vector
>   ...
> 
Hi Jeremiah,
	Could you please help to confirm which commit caused the
regression?
1) x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary
buffer
2) x86/irq: Fix a race condition between vector assigning and cleanup

Thanks,
Gerry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/