linux-kernel - Re: [PATCH] iommu:Check that iommu_device_create has completed successfully in alloc_iommu

Open Source and information security mailing list archives

Message-ID: <CAKT61h-n6=enWPAmEkPE36VZvrGFn9_Zj0y4+DdkOB33jyELUw@mail.gmail.com>
Date:	Tue, 29 Dec 2015 15:15:46 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	Joerg Roedel <joro@...tes.org>, iommu@...ts.linux-foundation.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu:Check that iommu_device_create has completed
 successfully in alloc_iommu

2015-12-29 13:10 GMT+08:00 Nicholas Krause <xerofoify@...il.com>:
> This adds the proper check to alloc_iommu to make sure that the call
> to iommu_device_create has completed successfully and if not return
> to the caller the error code returned after freeing up resources
> allocated previously by alloc_iommu.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/iommu/dmar.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
> index 80e3c17..27333b6 100644
> --- a/drivers/iommu/dmar.c
> +++ b/drivers/iommu/dmar.c
> @@ -1069,9 +1069,12 @@ static int alloc_iommu(struct dmar_drhd_unit *drhd)
>                 iommu->iommu_dev = iommu_device_create(NULL, iommu,
>                                                        intel_iommu_groups,
>                                                        "%s", iommu->name);
> +       if (IS_ERR(iommu->iommu_dev)) {
> +               err = PTR_ERR(iommu->iommu_dev);
> +               goto err_unmap;
> +       }

If so, will this bad 'iommu->iommu_dev' break your iommu work?  It
seems not necessary.

>
>         return 0;
> -
>  err_unmap:
>         unmap_iommu(iommu);
>  error_free_seq_id:
> --
> 2.5.0
>
> _______________________________________________
> iommu mailing list
> iommu@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu

-- 
---
Vincent Wan(Zongshun)
www.mcuos.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives