linux-kernel - Re: [PATCH] mwifiex: correctly handling kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151229.150928.1955323552394590874.davem@davemloft.net>
Date:	Tue, 29 Dec 2015 15:09:28 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	wuninsu@...il.com
Cc:	akarwar@...vell.com, nishants@...vell.com, kvalo@...eaurora.org,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, taesoo@...ech.edu,
	yeongjin.jang@...ech.edu, insu@...ech.edu, changwoo@...ech.edu
Subject: Re: [PATCH] mwifiex: correctly handling kzalloc

From: Insu Yun <wuninsu@...il.com>
Date: Tue, 29 Dec 2015 14:55:25 -0500

> Since kzalloc can be failed in memory pressure,
> it needs to be handled as above kzalloc.
> 
> Signed-off-by: Insu Yun <wuninsu@...il.com>
> ---
>  drivers/net/wireless/mwifiex/sdio.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c
> index 78a8474..d114934 100644
> --- a/drivers/net/wireless/mwifiex/sdio.c
> +++ b/drivers/net/wireless/mwifiex/sdio.c
> @@ -2053,8 +2053,14 @@ static int mwifiex_init_sdio(struct mwifiex_adapter *adapter)
>  	/* Allocate skb pointer buffers */
>  	card->mpa_rx.skb_arr = kzalloc((sizeof(void *)) *
>  				       card->mp_agg_pkt_limit, GFP_KERNEL);
> +	if (!card->mpa_rx.skb_arr)
> +		return -ENOMEM;
> +
>  	card->mpa_rx.len_arr = kzalloc(sizeof(*card->mpa_rx.len_arr) *
>  				       card->mp_agg_pkt_limit, GFP_KERNEL);
> +	if (!card->mpa_rx.len_arr)
> +		return -ENOMEM;
> +
>  	ret = mwifiex_alloc_sdio_mpa_buffers(adapter,
>  					     card->mp_tx_agg_buf_size,
>  					     card->mp_rx_agg_buf_size);

You can't just return, you have to release all of the resources
acquired above the point where the error happens.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/