linux-kernel - Re: [PATCH 3/6] iommu/amd: Introduce amd_iommu_get_num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5682F931.3010400@amd.com>
Date:	Tue, 29 Dec 2015 15:20:49 -0600
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	Joerg Roedel <joro@...tes.org>
CC:	<bp@...en8.de>, <peterz@...radead.org>, <mingo@...hat.com>,
	<acme@...nel.org>, <linux-kernel@...r.kernel.org>,
	<iommu@...ts.linux-foundation.org>
Subject: Re: [PATCH 3/6] iommu/amd: Introduce amd_iommu_get_num_iommus()

Hi Jorge,

On 12/28/15 09:43, Joerg Roedel wrote:
> On Tue, Dec 22, 2015 at 01:19:14PM -0600, Suthikulpanit, Suravee wrote:
>> This patch introduces amd_iommu_get_num_iommus(). Initially, this is
>> intended to be used by Perf AMD IOMMU driver.
>>
>> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
>> ---
>>   drivers/iommu/amd_iommu_init.c            | 16 ++++++++++++++++
>>   include/linux/perf/perf_event_amd_iommu.h |  2 ++
>>   2 files changed, 18 insertions(+)
>>
>> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
>> index 275c0f5..9c62613 100644
>> --- a/drivers/iommu/amd_iommu_init.c
>> +++ b/drivers/iommu/amd_iommu_init.c
>> @@ -2244,6 +2244,22 @@ bool amd_iommu_v2_supported(void)
>>   }
>>   EXPORT_SYMBOL(amd_iommu_v2_supported);
>>
>> +static int amd_iommu_cnt;
>> +
>> +int amd_iommu_get_num_iommus(void)
>> +{
>> +	struct amd_iommu *iommu;
>> +
>> +	if (amd_iommu_cnt)
>> +		return amd_iommu_cnt;
>> +
>> +	for_each_iommu(iommu)
>> +		amd_iommu_cnt++;
>
> It is better to set amd_iommu_cnt during IOMMU initialization. You can
> just increment this value after an IOMMU has been set up.
>
>
>
> 	Joerg
>

Sure. I'll take care of this in V2.

Thanks,
Suravee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/