linux-kernel - Re: [PATCH v3 1/4] ocfs2: export ocfs2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Dec 2015 13:38:44 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Gang He <ghe@...e.com>
Cc:	mfasheh@...e.com, rgoldwyn@...e.de, linux-kernel@...r.kernel.org,
	ocfs2-devel@....oracle.com
Subject: Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check

On Fri, 25 Dec 2015 15:16:16 +0800 Gang He <ghe@...e.com> wrote:

> Export ocfs2_kset object from ocfs2_stackglue kernel module,
> then online file check code will create the related sysfiles
> under ocfs2_kset object.
> 
> ...
>
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -629,7 +629,8 @@ static struct attribute_group ocfs2_attr_group = {
>  	.attrs = ocfs2_attrs,
>  };
>  
> -static struct kset *ocfs2_kset;
> +struct kset *ocfs2_kset;
> +EXPORT_SYMBOL_GPL(ocfs2_kset);

The EXPORT_SYMBOL is only needed if this symbol is to be referred to
from a different module.  That isn't the case here - everything which
refers to ocfs2_kset is linked into ocfs2.ko, correct?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/