linux-kernel - Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Dec 2015 17:02:03 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Ksenija Stanojević <ksenija.stanojevic@...il.com>
Cc:	willy@...a-x.org, devel@...verdev.osuosl.org,
	Greg KH <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

On Wed, Dec 30, 2015 at 11:13:40AM +0100, Ksenija Stanojević wrote:
> On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee
> <sudipm.mukherjee@...il.com> wrote:
> > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
> >> Split comment in order to fit into 80 characters per line.
> >> Found by checkpatch.pl
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@...il.com>
> >> ---
> >
> > Instead of multiline maybe this is better:
> >
> > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> > index 79ac192..3525919 100644
> > --- a/drivers/staging/panel/panel.c
> > +++ b/drivers/staging/panel/panel.c
> > @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
> >                 lcd_send_serial(0x5F);  /* R/W=W, RS=1 */
> >                 lcd_send_serial(' ' & 0x0F);
> >                 lcd_send_serial((' ' >> 4) & 0x0F);
> > -               usleep_range(40, 100);  /* the shortest data takes at least 40 us */
> > +               /* the shortest data takes at least 40 us */
> > +               usleep_range(40, 100);
> >         }
> >         spin_unlock_irq(&pprt_lock);
> 
> It's already been done by Bijosh Thykkoottathil:
> https://lkml.org/lkml/2015/12/18/681

But I think not yet accepted by Greg. And his commit message doesnot
mention what coding style errors he has fixed. Usually Greg will not
accept them.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/