linux-kernel - Re: [PATCH v4 14/24] clk: pwm: use pwm_get/set_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151230210511.19557.73321@quark.deferred.io>
Date:	Wed, 30 Dec 2015 13:05:11 -0800
From:	Michael Turquette <mturquette@...libre.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	"Thierry Reding" <thierry.reding@...il.com>,
	linux-pwm@...r.kernel.org
Cc:	"Stephen Boyd" <sboyd@...eaurora.org>, linux-clk@...r.kernel.org,
	"Mark Brown" <broonie@...nel.org>,
	"Liam Girdwood" <lgirdwood@...il.com>,
	"Kamil Debski" <k.debski@...sung.com>, lm-sensors@...sensors.org,
	"Jean Delvare" <jdelvare@...e.com>,
	"Guenter Roeck" <linux@...ck-us.net>,
	"Dmitry Torokhov" <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, "Bryan Wu" <cooloney@...il.com>,
	"Richard Purdie" <rpurdie@...ys.net>,
	"Jacek Anaszewski" <j.anaszewski@...sung.com>,
	linux-leds@...r.kernel.org,
	"Maxime Ripard" <maxime.ripard@...e-electrons.com>,
	"Chen-Yu Tsai" <wens@...e.org>, linux-sunxi@...glegroups.com,
	"Joachim Eastwood" <manabian@...il.com>,
	"Thomas Petazzoni" <thomas.petazzoni@...e-electrons.com>,
	"Heiko Stuebner" <heiko@...ech.de>,
	linux-rockchip@...ts.infradead.org,
	"Jingoo Han" <jingoohan1@...il.com>,
	"Lee Jones" <lee.jones@...aro.org>, linux-fbdev@...r.kernel.org,
	"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
	"Tomi Valkeinen" <tomi.valkeinen@...com>,
	"Robert Jarzmik" <robert.jarzmik@...e.fr>,
	"Alexandre Belloni" <alexandre.belloni@...e-electrons.com>,
	"Julia Lawall" <Julia.Lawall@...6.fr>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	"Boris Brezillon" <boris.brezillon@...e-electrons.com>
Subject: Re: [PATCH v4 14/24] clk: pwm: use pwm_get/set_default_xxx() helpers where
 appropriate

Hi Boris,

Quoting Boris Brezillon (2015-11-16 00:56:37)
> pwm_set/get_default_xxx() helpers have been introduced to differentiate
> the default PWM states (those retrieved through DT, PWM lookup table or
> statically assigned by the driver) and the current ones.
> Make use of those helpers where appropriate.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> ---
>  drivers/clk/clk-pwm.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c
> index b6306a2..642a49a 100644
> --- a/drivers/clk/clk-pwm.c
> +++ b/drivers/clk/clk-pwm.c
> @@ -71,23 +71,23 @@ static int clk_pwm_probe(struct platform_device *pdev)
>         if (IS_ERR(pwm))
>                 return PTR_ERR(pwm);
>  
> -       if (!pwm_get_period((pwm))) {
> +       if (!pwm_get_default_period((pwm))) {

The change itself looks fine, but the semantic patch added extra parens.
Can you remove them? After doing so feel free to add:

Acked-by: Michael Turquette <mturquette@...libre.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/