linux-kernel - Re: [PATCH v6 13/20] arm64: ilp32: share aarch32 syscall wrappers to ilp32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1875383.FRuM9m49WW@wuerfel>
Date:	Wed, 30 Dec 2015 23:36:27 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Yury Norov <ynorov@...iumnetworks.com>, pinskia@...il.com,
	Prasun.Kapoor@...iumnetworks.com,
	Catalin Marinas <catalin.marinas@....com>,
	Nathan_Lynch@...tor.com, linux-kernel@...r.kernel.org,
	agraf@...e.de, klimov.linux@...il.com, broonie@...nel.org,
	jan.dakinevich@...il.com, ddaney.cavm@...il.com, schwab@...e.de,
	bamvor.zhangjian@...wei.com, philipp.tomsich@...obroma-systems.com,
	joseph@...esourcery.com, christoph.muellner@...obroma-systems.com
Subject: Re: [PATCH v6 13/20] arm64: ilp32: share aarch32 syscall wrappers to ilp32

On Wednesday 30 December 2015 20:29:05 Yury Norov wrote:
> 
> So. For ilp32, the only wrapper left here, is compat_sys_mmap2_wrapper.
> But this is workaroud, as comment tells:
>         Note: off_4k (w5) is always in units of 4K. If we can't do the
>         requested offset because it is not page-aligned, we return -EINVAL.
> 
> Not sure we should pull it to ILP32. If so, we can call sys_mmap_pgoff()
> directly. And we don't need this patch at all therefore. Any throughts?
> 
> 

I think providing the 64-bit version of sys_mmap() would be the simplest
API, as that avoids any possible confusion about the shift amount (hardcoded
12 bits vs PAGE_BITS). It fits in with the other syscalls that pass an loff_t
value here.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/