linux-kernel - Re: [uml-devel] [PATCH] um: link with -lpthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <781be574-7acc-4891-a12a-571f9e68e2dc@email.android.com>
Date:	Thu, 31 Dec 2015 17:21:43 +0100
From:	Thomas Meyer <thomas@...3r.de>
To:	Vegard Nossum <vegard.nossum@...cle.com>
Cc:	linux-kernel@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net,
	Richard Weinberger <richard@....at>
Subject: Re: [uml-devel] [PATCH] um: link with -lpthread

Am 31.12.2015 5:06 nachm. schrieb Vegard Nossum <vegard.nossum@...cle.com>:
>
> Similarly to commit fb1770aa78a43530940d0c2dd161e77bc705bdac, with gcc 5 
> on Ubuntu and CONFIG_STATIC_LINK=y I was seeing these linker errors: 

Hi,

Oops, yes this patch looks good to me. Honestly I did never test the static link case. Sorry.

With kind regards
Thomas

>
> /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/librt.a(timer_create.o): In function `__timer_create_new': 
> (.text+0xcd): undefined reference to `pthread_once' 
> /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/librt.a(timer_create.o): In function `__timer_create_new': 
> (.text+0x126): undefined reference to `pthread_attr_init' 
> /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/librt.a(timer_create.o): In function `__timer_create_new': 
> (.text+0x168): undefined reference to `pthread_attr_setdetachstate' 
> [...] 
>
> Obviously we also need -lpthread for librt.a. 
>
> Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com> 
> --- 
> scripts/link-vmlinux.sh | 2 +- 
> 1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh 
> index dacf71a..ba6c34e 100755 
> --- a/scripts/link-vmlinux.sh 
> +++ b/scripts/link-vmlinux.sh 
> @@ -62,7 +62,7 @@ vmlinux_link() 
> -Wl,--start-group                                    \ 
> ${KBUILD_VMLINUX_MAIN}                      \ 
> -Wl,--end-group                                      \ 
> - -lutil -lrt ${1} 
> + -lutil -lrt -lpthread ${1} 
> rm -f linux 
> fi 
> } 
> -- 
> 1.9.1 
>
>
> ------------------------------------------------------------------------------ 
> _______________________________________________ 
> User-mode-linux-devel mailing list 
> User-mode-linux-devel@...ts.sourceforge.net 
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel