linux-kernel - Re: [PATCH 1/4] spi: mediatek: merge all identical compat to mtk_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Dec 2015 09:32:07 +0100
From:	Matthias Brugger <matthias.bgg@...il.com>
To:	Leilk Liu <leilk.liu@...iatek.com>, Mark Brown <broonie@...nel.org>
Cc:	Mark Rutland <mark.rutland@....com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/4] spi: mediatek: merge all identical compat to
 mtk_common_compat



On 31/12/15 03:59, Leilk Liu wrote:
> This patch merge all identical compat into on mtk_common_compat
> and used for all compatible soc.
>
> Signed-off-by: Leilk Liu <leilk.liu@...iatek.com>
> ---

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

>   drivers/spi/spi-mt65xx.c |   15 ++++++++++-----
>   1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
> index 563954a..3573c09 100644
> --- a/drivers/spi/spi-mt65xx.c
> +++ b/drivers/spi/spi-mt65xx.c
> @@ -95,8 +95,7 @@ struct mtk_spi {
>   	const struct mtk_spi_compatible *dev_comp;
>   };
>
> -static const struct mtk_spi_compatible mt6589_compat;
> -static const struct mtk_spi_compatible mt8135_compat;
> +static const struct mtk_spi_compatible mtk_common_compat;
>   static const struct mtk_spi_compatible mt8173_compat = {
>   	.need_pad_sel = true,
>   	.must_tx = true,
> @@ -112,9 +111,15 @@ static const struct mtk_chip_config mtk_default_chip_info = {
>   };
>
>   static const struct of_device_id mtk_spi_of_match[] = {
> -	{ .compatible = "mediatek,mt6589-spi", .data = (void *)&mt6589_compat },
> -	{ .compatible = "mediatek,mt8135-spi", .data = (void *)&mt8135_compat },
> -	{ .compatible = "mediatek,mt8173-spi", .data = (void *)&mt8173_compat },
> +	{ .compatible = "mediatek,mt6589-spi",
> +		.data = (void *)&mtk_common_compat,
> +	},
> +	{ .compatible = "mediatek,mt8135-spi",
> +		.data = (void *)&mtk_common_compat,
> +	},
> +	{ .compatible = "mediatek,mt8173-spi",
> +		.data = (void *)&mt8173_compat,
> +	},
>   	{}
>   };
>   MODULE_DEVICE_TABLE(of, mtk_spi_of_match);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/