linux-kernel - Re: [PATCH] clk: gpio: fix memory leak in of_gpio_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160101055632.21738.88763@quark.deferred.io>
Date:	Thu, 31 Dec 2015 21:56:32 -0800
From:	Michael Turquette <mturquette@...libre.com>
To:	Brian Norris <computersforpeace@...il.com>,
	"Stephen Boyd" <sboyd@...eaurora.org>
Cc:	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Brian Norris" <computersforpeace@...il.com>,
	"Jyri Sarha" <jsarha@...com>, "Sergej Sawazki" <ce3a@....de>
Subject: Re: [PATCH] clk: gpio: fix memory leak in of_gpio_clk_setup()

Quoting Brian Norris (2015-12-16 10:28:31)
> Reported by Coverity.
> 
> Fixes: f66541ba02d5 ("clk: gpio: Get parent clk names in of_gpio_clk_setup()")
> Signed-off-by: Brian Norris <computersforpeace@...il.com>
> Cc: Jyri Sarha <jsarha@...com>
> Cc: Sergej Sawazki <ce3a@....de>
> Cc: Stephen Boyd <sboyd@...eaurora.org>

Thanks for the fix. I already applied this one:

http://lkml.kernel.org/r/<1450852439-366-1-git-send-email-sudipm.mukherjee@...il.com>

Regards,
Mike

> ---
>  drivers/clk/clk-gpio.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
> index 335322dc403f..c1baa89cbf91 100644
> --- a/drivers/clk/clk-gpio.c
> +++ b/drivers/clk/clk-gpio.c
> @@ -294,8 +294,10 @@ static void __init of_gpio_clk_setup(struct device_node *node,
>         num_parents = of_clk_get_parent_count(node);
>  
>         parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL);
> -       if (!parent_names)
> +       if (!parent_names) {
> +               kfree(data);
>                 return;
> +       }
>  
>         for (i = 0; i < num_parents; i++)
>                 parent_names[i] = of_clk_get_parent_name(node, i);
> -- 
> 2.6.0.rc2.230.g3dd15c0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/