linux-kernel - Re: [PATCH] staging: most: add __iomem for io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160102215942.GA3847@hugo-core>
Date:	Sat, 2 Jan 2016 21:59:42 +0000
From:	Hugo Camboulive <hugo.camboulive@...il.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	gregkh@...uxfoundation.org, chaehyun.lim@...il.com,
	christian.gromm@...rochip.com, andrey.shvetsov@....de,
	sudipm.mukherjee@...il.com, joe@...ches.com,
	shraddha.6596@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: most: add __iomem for io_base and registers

On Saturday 02 Jan 2016 20:33:23 (+0000), Al Viro wrote:
> On Sat, Jan 02, 2016 at 08:30:21PM +0000, Hugo Camboulive wrote:
> > This removes a few Sparse warnings.
> 
> > +	g.dim2 = (struct dim2_regs __iomem *)dim_base_address;
> 
> > -u8 dim_startup(void *dim_base_address, u32 mlb_clock);
> > +u8 dim_startup(void __iomem *dim_base_address, u32 mlb_clock);
> 
> Umm...  Why not have it take struct dim2_regs __iomem * as argument, and
> to hell with that cast?
Oh, right. I wasn't sure if the original void* was there for a reason. I'll send a v2.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/