| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160103005620.GM2860@var.home> Date: Sun, 3 Jan 2016 01:56:20 +0100 From: Samuel Thibault <samuel.thibault@...-lyon.org> To: William Hubbs <w.d.hubbs@...il.com>, Chris Brannon <chris@...-brannons.com>, Kirk Reiser <kirk@...sers.ca>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, speakup@...ux-speakup.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Staging: speakup: Fix getting port information covici@....covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > I had a patch which also worked, but yours may be better -- I enclose it > here for your information. Well, it's not up to serialio.h to include things for serialio.c. That however makes me realize that the culprit is actually f79b0d9 (which actually doesn't make much sense since linux/serial.h is getting included a couple of lines above...). I don't know what this "use <linux/serial.h> instead <asm/serial.h>" warning is about, but *no* header in include/ includes asm/serial.h, so there is no way to get the SERIAL_PORT_DFNS definition just by including linux/serial.h, we really need asm/serial.h, just like 8250*.c do. So we really need serialio.c to include linux/serial_core.h then asm/serial.h, as my patch does. Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists