lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Jan 2016 13:48:16 +0100 (CET) From: Julia Lawall <julia.lawall@...6.fr> To: SF Markus Elfring <elfring@...rs.sourceforge.net> cc: rtc-linux@...glegroups.com, Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_interrupt() On Sun, 3 Jan 2016, SF Markus Elfring wrote: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Sun, 3 Jan 2016 09:00:30 +0100 > > Pass the address of the data structure element "time" directly in calls > of the function "rtc_update_irq" instead of an extra initialisation > for one local variable at the beginning. Why is it better? julia > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> > --- > drivers/rtc/rtc-ab-b5ze-s3.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c > index e3a015a..88f1d0b 100644 > --- a/drivers/rtc/rtc-ab-b5ze-s3.c > +++ b/drivers/rtc/rtc-ab-b5ze-s3.c > @@ -816,7 +816,6 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > struct i2c_client *client = data; > struct device *dev = &client->dev; > struct abb5zes3_rtc_data *rtc_data = dev_get_drvdata(dev); > - struct rtc_device *rtc = rtc_data->rtc; > u8 regs[ABB5ZES3_CTRL_SEC_LEN]; > int ret, handled = IRQ_NONE; > > @@ -844,8 +843,7 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > /* Check alarm flag */ > if (regs[ABB5ZES3_REG_CTRL2] & ABB5ZES3_REG_CTRL2_AF) { > dev_dbg(dev, "RTC alarm!\n"); > - > - rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF); > + rtc_update_irq(rtc_data->rtc, 1, RTC_IRQF | RTC_AF); > > /* Acknowledge and disable the alarm */ > _abb5zes3_rtc_clear_alarm(dev); > @@ -857,8 +855,7 @@ static irqreturn_t _abb5zes3_rtc_interrupt(int irq, void *data) > /* Check watchdog Timer A flag */ > if (regs[ABB5ZES3_REG_CTRL2] & ABB5ZES3_REG_CTRL2_WTAF) { > dev_dbg(dev, "RTC timer!\n"); > - > - rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF); > + rtc_update_irq(rtc_data->rtc, 1, RTC_IRQF | RTC_AF); > > /* > * Acknowledge and disable the alarm. Note: WTAF > -- > 2.6.3 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists