lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 3 Jan 2016 19:30:12 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Li Yang <leoli@...escale.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Gao Pan <b54642@...escale.com>
Subject: Re: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional

On Mon, Nov 30, 2015 at 01:55:19PM +0100, Linus Walleij wrote:
> On Fri, Nov 20, 2015 at 10:45 PM, Li Yang <leoli@...escale.com> wrote:
> 
> > -       if (IS_ERR(i2c_imx->pinctrl)) {
> > +       /* bailout on -ENOMEM or -EPROBE_DEFER, continue for other errors */
> > +       if (PTR_ERR(i2c_imx->pinctrl) == -ENOMEM ||
> > +                       PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) {
> 
> This is one of the evils of deferred probe: you never know if
> something will eventually turn up. It feels wrong to bail out
> on deferred probe...
> 
> I have no better idea though.
> Acked-by

Linus, proper ack next time please, so patchwork will pick it up
automatically.

Li Yang: There have been some other changes to the imx driver. Could you
rebase against my for-next or for-4.5 and add Linus' ack? Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists