linux-kernel - Re: [PATCH 1/1] HID: multitouch: enable palm rejection if device implements confidence usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+gG=EzUADfseJQ_bY9KXQ_+YNrpS8B6B9eRK_gcyD6aZpg9w@mail.gmail.com>
Date:	Mon, 4 Jan 2016 09:35:46 +0100
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Allen Hung <allen_hung@...l.com>
Cc:	Jiri Kosina <jikos@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-input <linux-input@...r.kernel.org>
Subject: Re: [PATCH 1/1] HID: multitouch: enable palm rejection if device
 implements confidence usage

Hi Allen,

On Mon, Dec 21, 2015 at 10:45 AM, Allen Hung <allen_hung@...l.com> wrote:
> On 12/18/2015 05:52 AM, Benjamin Tissoires wrote:
>> On Thu, Nov 26, 2015 at 3:21 PM, Jiri Kosina <jikos@...nel.org> wrote:
>>> On Fri, 20 Nov 2015, Allen Hung wrote:
>>>
>>>> The usage Confidence is mandary to Windows Precision Touchpad devices. The
>>>> appearance of this usage is checked in hidinput_connect but the quirk
>>>> MT_QUIRK_VALID_IS_CONFIDENCE is not applied to device accordingly.
>>>> Apply this quirk and also remove quirk MT_QUIRK_ALWAYS_VALID to enable palm
>>>> rejection for the WIN 8 touchpad devices which have implemented usage
>>>> Confidence in its input reports.
>>>>
>>>> Tested on Dell XPS 13 laptop.
>>>>
>>>> Signed-off-by: Allen Hung <allen_hung@...l.com>
>>> Applied to for-4.5/multitouch. Thanks,
>>>
>> Allen, looks like the Dell XPS13 2015 (or was it the 2014?) has
>> problems with your patch:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1292583 (we backported
>> this change in the Fedora kernel 4.2.7).
>>
>> Would you mind checking that this patch does not create regressions on
>> older series of laptops?
>>
>> Thanks in advance.
>>
>> Cheers,
>> Benjamin
> Hi Benjamin,
>
> It looks like a XPS13 2014 but I can confirm this with my colleagues who are in charge of this product line. I don't mind checking this patch with more older series of laptops. I will do it and let you know the status. Should I also test the machines with Fedora 23, or just go with Ubuntu OS? The XPS machines are shipped with Ubuntu.
> Btw, the issue reporter said she/he cannot reproduce the issue (posted on Dec. 18).
>

[Sorry for the late answer, but you guessed the holiday season did not help :)]

I think I'll just ask the reporter to confirm he can not reproduce and
then close the downstream bug.
Unless other people complains, I think we can just keep the current
state and wait :)

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/