linux-kernel - Re: [PATCH v3] i2c: designware: Do not require clock when SSCN and FFCN are provided

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <568A8D06.2010901@amd.com>
Date:	Mon, 4 Jan 2016 09:17:26 -0600
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	<mika.westerberg@...ux.intel.com>, <wsa@...-dreams.de>
CC:	<jarkko.nikula@...ux.intel.com>, <lho@....com>, <Ken.Xue@....com>,
	<linux-i2c@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] i2c: designware: Do not require clock when SSCN and
 FFCN are provided

Hi Andy,

On 12/23/2015 12:27 PM, Andy Shevchenko wrote:
>> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
>> >b/drivers/i2c/busses/i2c-designware-platdrv.c
>> >index 8ffc36b..04edd09 100644
>> >--- a/drivers/i2c/busses/i2c-designware-platdrv.c
>> >+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> Can we introduce
>
> static int i2c_dw_plat_prepare_clk(struct dw_i2c_dev *i_dev, bool
> prepare)
> {
> 	if (IS_ERR(i_dev->clk))
> 		return PTR_ERR(i_dev->clk);
>
> 	if (prepare)
> /* REMOVEME: Yes, you have to check return value and this is one
> benefit of this change */
> 		return clk_prepare_enable(i_dev->clk);
>
> 	clk_disable_unprepare(i_dev->clk);
> 	return 0;
> }
>
> and…
>

Yes, I think this change. I'll put this in the V4, and send out soon.

Suravee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/