linux-kernel - Re: [PATCH v2] ehci-hcd: Disable memory-write-invalidate when the driver is removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1601041026510.1630-100000@iolanthe.rowland.org>
Date:	Mon, 4 Jan 2016 10:27:21 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Jia-Ju Bai <baijiaju1990@....com>
cc:	sergei.shtylyov@...entembedded.com, <gregkh@...uxfoundation.org>,
	USB list <linux-usb@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ehci-hcd: Disable memory-write-invalidate when the
 driver is removed

On Mon, 4 Jan 2016, Jia-Ju Bai wrote:

> The driver calls pci_set_mwi to enable memory-write-invalidate when it 
> is initialized, but does not call pci_clear_mwi when it is removed. Many 
> other drivers calls pci_clear_mwi when pci_set_mwi is called, such as 
> r8169, 8139cp and e1000.
> 
> This patch adds a function "ehci_pci_remove" to remove the pci driver.
> This function calls pci_clear_mwi and usb_hcd_pci_remove, which can 
> fix the problem.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@....com>
> ---
>  drivers/usb/host/ehci-pci.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> index 2a5d2fd..3b3649d 100644
> --- a/drivers/usb/host/ehci-pci.c
> +++ b/drivers/usb/host/ehci-pci.c
> @@ -377,6 +377,12 @@ static int ehci_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	return usb_hcd_pci_probe(pdev, id);
>  }
>  
> +static void ehci_pci_remove(struct pci_dev *pdev)
> +{
> +	pci_clear_mwi(pdev);
> +	usb_hcd_pci_remove(pdev);	
> +}
> +
>  /* PCI driver selection metadata; PCI hotplugging uses this */
>  static const struct pci_device_id pci_ids [] = { {
>  	/* handle any USB 2.0 EHCI controller */
> @@ -396,7 +402,7 @@ static struct pci_driver ehci_pci_driver = {
>  	.id_table =	pci_ids,
>  
>  	.probe =	ehci_pci_probe,
> -	.remove =	usb_hcd_pci_remove,
> +	.remove =	ehci_pci_remove,
>  	.shutdown = 	usb_hcd_pci_shutdown,
>  
>  #ifdef CONFIG_PM

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/