linux-kernel - Re: [PATCH v4.1 03/13] tools lib traceevent: Factor out and export print_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160104103127.786a2b8e@gandalf.local.home>
Date:	Mon, 4 Jan 2016 10:31:27 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH v4.1 03/13] tools lib traceevent: Factor out and export
 print_event_field[s]

On Wed, 23 Dec 2015 22:08:41 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

> The print_event_field() and print_event_fields() are to print basic
> information of a given field or event without the print format.  They'll
> be used by dynamic sort keys later.

Hi Namhyung,


> diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
> index 6fc83c7edbe9..600c73277a6f 100644
> --- a/tools/lib/traceevent/event-parse.h
> +++ b/tools/lib/traceevent/event-parse.h
> @@ -705,6 +705,10 @@ struct cmdline *pevent_data_pid_from_comm(struct pevent *pevent, const char *com
>  					  struct cmdline *next);
>  int pevent_cmdline_pid(struct pevent *pevent, struct cmdline *cmdline);
>  
> +void print_event_field(struct trace_seq *s, void *data,
> +		       struct format_field *field);
> +void print_event_fields(struct trace_seq *s, void *data,
> +			int size __maybe_unused, struct event_format *event);

I'm fine with the patch, but can you change the function names to be
less generic, as this will now be part of a library (that I hope will
become something supplied by distros soon).

Like:

pevent_print_field();
 and
pevent_print_fields();

Thanks!

-- Steve

>  void pevent_event_info(struct trace_seq *s, struct event_format *event,
>  		       struct pevent_record *record);
>  int pevent_strerror(struct pevent *pevent, enum pevent_errno errnum,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/