linux-kernel - Re: [PATCH 02/10] i2c-mux: move select and deselect ops to i2c_mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201601050030.kUEz8RKa%fengguang.wu@intel.com>
Date:	Tue, 5 Jan 2016 00:01:19 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Peter Rosin <peda@...ator.liu.se>
Cc:	kbuild-all@...org, Wolfram Sang <wsa@...-dreams.de>,
	Peter Rosin <peda@...ntia.se>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Peter Korsgaard <peter.korsgaard@...co.com>,
	Guenter Roeck <linux@...ck-us.net>, linux-i2c@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Rosin <peda@...ator.liu.se>
Subject: Re: [PATCH 02/10] i2c-mux: move select and deselect ops to
 i2c_mux_core

Hi Peter,

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.4-rc8 next-20160104]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Peter-Rosin/i2c-mux-cleanup-and-locking-update/20160104-231355
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/for-next
config: x86_64-randconfig-s4-01042328 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/media/dvb-frontends/si2168.c: In function 'si2168_probe':
   drivers/media/dvb-frontends/si2168.c:712:37: warning: passing argument 1 of 'i2c_add_mux_adapter' from incompatible pointer type [-Wincompatible-pointer-types]
     dev->adapter = i2c_add_mux_adapter(client->adapter, &client->dev,
                                        ^
   In file included from drivers/media/dvb-frontends/si2168_priv.h:23:0,
                    from drivers/media/dvb-frontends/si2168.c:17:
   include/linux/i2c-mux.h:53:21: note: expected 'struct i2c_mux_core *' but argument is of type 'struct i2c_adapter *'
    struct i2c_adapter *i2c_add_mux_adapter(struct i2c_mux_core *muxc,
                        ^
>> drivers/media/dvb-frontends/si2168.c:713:4: warning: passing argument 3 of 'i2c_add_mux_adapter' makes integer from pointer without a cast [-Wint-conversion]
       client, 0, 0, 0, si2168_select, si2168_deselect);
       ^
   In file included from drivers/media/dvb-frontends/si2168_priv.h:23:0,
                    from drivers/media/dvb-frontends/si2168.c:17:
   include/linux/i2c-mux.h:53:21: note: expected 'u32 {aka unsigned int}' but argument is of type 'struct i2c_client *'
    struct i2c_adapter *i2c_add_mux_adapter(struct i2c_mux_core *muxc,
                        ^
>> drivers/media/dvb-frontends/si2168.c:712:17: error: too many arguments to function 'i2c_add_mux_adapter'
     dev->adapter = i2c_add_mux_adapter(client->adapter, &client->dev,
                    ^
   In file included from drivers/media/dvb-frontends/si2168_priv.h:23:0,
                    from drivers/media/dvb-frontends/si2168.c:17:
   include/linux/i2c-mux.h:53:21: note: declared here
    struct i2c_adapter *i2c_add_mux_adapter(struct i2c_mux_core *muxc,
                        ^

vim +/i2c_add_mux_adapter +712 drivers/media/dvb-frontends/si2168.c

845f3505 Antti Palosaari 2014-04-10  706  		ret = -ENOMEM;
37b4e43d Olli Salonen    2014-08-05  707  		dev_err(&client->dev, "kzalloc() failed\n");
1ee5e7dd Antti Palosaari 2014-12-05  708  		goto err;
845f3505 Antti Palosaari 2014-04-10  709  	}
845f3505 Antti Palosaari 2014-04-10  710  
845f3505 Antti Palosaari 2014-04-10  711  	/* create mux i2c adapter for tuner */
6307b560 Antti Palosaari 2014-11-25 @712  	dev->adapter = i2c_add_mux_adapter(client->adapter, &client->dev,
6307b560 Antti Palosaari 2014-11-25 @713  			client, 0, 0, 0, si2168_select, si2168_deselect);
bd01c766 Antti Palosaari 2014-11-25  714  	if (dev->adapter == NULL) {
4d6efc7a Luis Alves      2014-07-17  715  		ret = -ENODEV;
346d4900 Antti Palosaari 2014-12-05  716  		goto err_kfree;

:::::: The code at line 712 was first introduced by commit
:::::: 6307b560800fd92b915a851186653317460039ad [media] si2168: carry pointer to client instead of state

:::::: TO: Antti Palosaari <crope@....fi>
:::::: CC: Mauro Carvalho Chehab <mchehab@....samsung.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (22271 bytes)