linux-kernel - Re: [PATCH] OrangeFS: constify export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOg9mSSmMTyAy0m7z9iYdHn_zK44xUx9yJ1Q6rAYCv7ZPPLMVA@mail.gmail.com>
Date:	Mon, 4 Jan 2016 11:18:00 -0500
From:	Mike Marshall <hubcap@...ibond.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] OrangeFS: constify export_operations structures

Hi Julia... thanks for the patch... I've applied it to my github repo,
so it will be in the next push to kernel.org.

Orangefs is still out-of-tree (only temporarily I hope ;-) so I guess I
don't belong in the MAINTAINERS file yet...

-Mike

On Fri, Jan 1, 2016 at 4:01 AM, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> This export_operations structure is never modified, so declare it as const.
> Most other structures of this type are already const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
>
> ---
>
> Mike, I saw your name on all of the patches for this driver, but you aren't
> in the MAINTAINERS file.  If you are the maintainer of this file, maybe you
> should add yourself there.
>
>  fs/orangefs/super.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c
> index 52bc522..bee67b3 100644
> --- a/fs/orangefs/super.c
> +++ b/fs/orangefs/super.c
> @@ -342,7 +342,7 @@ out:
>         return type;
>  }
>
> -static struct export_operations orangefs_export_ops = {
> +static const struct export_operations orangefs_export_ops = {
>         .encode_fh = orangefs_encode_fh,
>         .fh_to_dentry = orangefs_fh_to_dentry,
>  };
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/