linux-kernel - [PATCH 07/17] usb: host: ehci-dbg: fix unsigned comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon,  4 Jan 2016 17:09:52 -0300
From:	"Geyslan G. Bem" <geyslan@...il.com>
To:	unlisted-recipients:; (no To-header on input)
Cc:	"Geyslan G. Bem" <geyslan@...il.com>, linux-kernel@...r.kernel.org,
	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org
Subject: [PATCH 07/17] usb: host: ehci-dbg: fix unsigned comparison

This patch fixes an unsigned comparison to less than 0.

Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
---

Notes:
    I'm not sure about that comparison because in qh_lines() temp receives
    the snprintf() return and thereafter occurs this comparison:
    
    if (size < temp)
       	   temp = size;
    
    Is it a test of string truncation right? That possibility is being
    treated. But if after some snprintf returns the temp is exactly size
    minus 1 (trailing null)? Could this scenario happen? If yes, I think
    size could be not counting correctly. Let me know more about it.

 drivers/usb/host/ehci-dbg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 980ca55..1645120 100644
--- a/drivers/usb/host/ehci-dbg.c
+++ b/drivers/usb/host/ehci-dbg.c
@@ -542,7 +542,7 @@ static ssize_t fill_async_buffer(struct debug_buffer *buf)
 		next += temp;
 
 		list_for_each_entry(qh, &ehci->async_unlink, unlink_node) {
-			if (size <= 0)
+			if (size == 0)
 				break;
 			qh_lines(ehci, qh, &next, &size);
 		}
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/