linux-kernel - Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Jan 2016 21:30:46 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Dinh Nguyen <dinguyen@...nsource.altera.com>
Cc:	tthayer@...nsource.altera.com, dinh.linux@...il.com,
	dougthompson@...ssion.com, mchehab@....samsung.com,
	linux@....linux.org.uk, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC
 Support

On Mon, Jan 04, 2016 at 02:04:08PM -0600, Dinh Nguyen wrote:
> altr_edac.c originally added support for SDRAM. Now we're adding support
> for L2 and OCRAM into the same file by using #ifdef
> CONFIG_EDAC_ALTERA_OCRAM and CONFIG_EDAC_ALTERA_L2C. So "clean" was to
> move the l2 and ocram implementation into separate files.

So what's wrong with adding those to the same file and using different
registration functions? Like xgene_edac does, for example.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/