linux-kernel - Re: v4.4-rc8: compile warning in scripts/recordmcount.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160104155213.33dd3f05@gandalf.local.home>
Date:	Mon, 4 Jan 2016 15:52:13 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Petri Gynther <pgynther@...gle.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: v4.4-rc8: compile warning in scripts/recordmcount.c

On Mon, 4 Jan 2016 12:22:58 -0800
Petri Gynther <pgynther@...gle.com> wrote:

> vmlinux: scripts/recordmcount.c: In function ‘main’:
> vmlinux: scripts/recordmcount.c:589:4: warning: format not a string
> literal and no format arguments [-Wformat-security]
> vmlinux:     sprintf("%s: failed\n", file);
> 
> Introduced by commit:
> commit a50bd43935586420fb75f4558369eb08566fac5e
> Author: Steven Rostedt (Red Hat) <rostedt@...dmis.org>
> Date:   Tue Dec 15 16:06:10 2015 -0500
> 
>     ftrace/scripts: Have recordmcount copy the object file
> 
> 
> Should that sprintf() be converted to fprintf(stderr, ...) instead?

I'm currently testing this patch:

http://lkml.kernel.org/r/1451516801-16951-1-git-send-email-colin.king@canonical.com

Seems my older gcc (and Fengguang Wu's gcc for his test box) doesn't
catch this.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/